https://bugzilla.redhat.com/show_bug.cgi?id=751119 --- Comment #8 from Jan Holcapek <holcapek@xxxxxxxxx> --- My apologies for being that late. Required items were mostly fixed by exploiting cpanspec to generate spec file from CPAN module. The only piece I had to change was source tarball url: generated one was invalid, so I picked working one. > I guess I could sponsor you. I'd like to see some more packages from you > first, though... perl-DBD-ODBC will come soon. > FIX: The package doesn't build (tested in Rawhide) due to missing build-time > dependencies. The following should be added: > perl(constant), perl(Sub::Exporter) Fixed. > FIX: I don't see a reason for those custom macros -- could you explain them? > Anyway, use %global instead of %define to comply with the Guidelines. Fixed. > FIX: Remove './Build test' from %build and move it to a (not currently > present) %check section Fixed. > FIX: Remove gcc from build-time dependencies. This is always present. Fixed. > FIX: Remove all those useless explicit Provides. Well, I'd love to, yet if I do so, I end up with these errors when about to install the resulting package: --cut-- [root@localhost perl-Judy]# rpm -U --test ../rpmbuild/RPMS/x86_64/perl-Judy-0.41-1.fc19.x86_64.rpm error: Failed dependencies: perl(Judy::1::_impl) is needed by perl-Judy-0.41-1.fc19.x86_64 perl(Judy::1::_obj) is needed by perl-Judy-0.41-1.fc19.x86_64 perl(Judy::1::_tie) is needed by perl-Judy-0.41-1.fc19.x86_64 perl(Judy::HS::_impl) is needed by perl-Judy-0.41-1.fc19.x86_64 perl(Judy::HS::_obj) is needed by perl-Judy-0.41-1.fc19.x86_64 perl(Judy::HS::_tie) is needed by perl-Judy-0.41-1.fc19.x86_64 perl(Judy::L::_impl) is needed by perl-Judy-0.41-1.fc19.x86_64 perl(Judy::L::_obj) is needed by perl-Judy-0.41-1.fc19.x86_64 perl(Judy::L::_tie) is needed by perl-Judy-0.41-1.fc19.x86_64 perl(Judy::Mem::_impl) is needed by perl-Judy-0.41-1.fc19.x86_64 perl(Judy::SL::_dump) is needed by perl-Judy-0.41-1.fc19.x86_64 perl(Judy::SL::_impl) is needed by perl-Judy-0.41-1.fc19.x86_64 perl(Judy::SL::_obj) is needed by perl-Judy-0.41-1.fc19.x86_64 perl(Judy::SL::_tie) is needed by perl-Judy-0.41-1.fc19.x86_64 perl(Judy::_tie) is needed by perl-Judy-0.41-1.fc19.x86_64 --cut-- I just don't know how to get rid of them except specifying explicit Provides. Any idea? > TODO: Improve the %description; this is just a copy of Summary and doesn't > really say much about the package. Fixed. > TODO: Unless you plan this for EPEL, remove the %clean section. I would actually like to push the package to EPEL eventually, so leaving %clean in place. > TODO: Unless you plan this for EPEL5 or older, drop the buildroot removal > from %install. If you do, add %defattr to %files and specify the Buildroot > tag. Fixed: don't plan for EPEL5, thus removed buildroot removal from %install. > TODO: Don't list manpages in %doc. They're marked as documentation > automatically. Also substitute the gzip extension with a glob; the > compression might change in the future. Be ready. Fixed by using cpanspec. > FIX: Don't use paths in %doc; simple '%doc Changes README' would do the > right thing (TM). Fixed. > FIX: Simply put: Use Module::Build as other packages do. You don't need > anything extra. E.g.: > > %build > perl Build.PL installdirs=vendor > ./Build > > %install > ./Build install destdir=%{buildroot} create_packlist=0 > find %{buildroot} -depth -type d -exec rmdir {} 2>/dev/null \; > %{_fixperms} %{buildroot}/* > > %check > ./Build test Hopefully fixed, I trusted cpanspec to do the right thing. > TIP: Simplify the %files list by using globs. Fixed. > FIX: Your Version is missing the %dist-tag. Add it. Fixed. > TIP: What's the reason for the patch? Explain it in a comment. As the patch name suggests, it attempts to avoid using Alien::Judy module, which serves the only purpose of looking up Judy headers in build time, and Judy shared library in runtime. Since Judy-devel package delivers header into standard location, and Judy package does so for shared library, there's no need for this extra tooling. -- Also, I have updated the spec with the latest upstream version 0.41: https://github.com/holcapek/perl-Judy/raw/master/perl-Judy.spec https://github.com/holcapek/perl-Judy/raw/master/perl-Judy-0.41-1.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review