https://bugzilla.redhat.com/show_bug.cgi?id=1021749 --- Comment #11 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- Result is much better :) as test suite is useful FYI: https://admin.fedoraproject.org/updates/php-password-compat-1.0.0-5.git58151cf.el6 Just a small problem: sources should not be conditionalized. You could have provided 2 spec files, a fedora specific one and another for epel-6. This were fine. You can also provide a generic spec file for all branches. This is fine and acceptable. But in this case the spec must really be generic, so the .src.rpm must include all sources and patches to be usable on all branches (else, among other bad side effects, git merge/cherry-pick will not work, because of conflict on the "sources" files). So you need to have Source1 for Icu 1.1.0 and Source2 for Icu 1.2.0 and only use %{?el6} for %setup Tips: I think you can even use (as I think testing icu version is closer to upstream documented depencency). Of course this need BR pkgconfig(icu-i18n) if pkg-config icu-i18n --atleast-version=4.4 then tar xzf %{SOURCE1} --strip-components 1 else tar xzf %{SOURCE2} --strip-components 1 fi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review