[Bug 1014738] Review Request: python-astropy - A Community Python Library for Astronomy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1014738



--- Comment #18 from Sergio Pascual <sergio.pasra@xxxxxxxxx> ---
(In reply to Michael Schwendt from comment #16)

> * How are the two -devel package supposed to work? 
I honestly do not know so I have asked upstream. astropy should provide
something like 'numpy.get_include' to be able to get the headers but I can't
find it in the source code.

I can remove the -devel packages and do as numpy does, with all the devel files
in the main package, but I would like to know the reviewer's opinion.

Strangely enough, numpy package provides a symlink from /usr/include/numpy to 
$libdir/python2.7/site-packages/numpy/core/include/numpy 

I don't know how this linking plays well with different architectures (having
both numpy.i686 and numpy.x86_64) or stacks (python2-numpy and python3-numpy)

> 
> 
> > %exclude %{_bindir}/fitsdiff
> > %exclude %{_bindir}/fitscheck
> 
> Why are they excluded?
> 

As Christian said, these are in pyfits also. astropy is meant to replace
pyfits, but it is not a drop in replacement. I do not want to start playing
with Conflicts at this point si I exclude them.

> 
> > -rwxr-xr-x  /usr/bin/volint
> > -rwxr-xr-x  /usr/bin/wcslint
> 
> These are included in both the Python package and the Python 3 based
> package. But in python-astropy, the files contain a /usr/bin/python3
> shebang. -> blocker!
> And with a corrected shebang, the packages would conflict. -> blocker!
> 
> $ rpm -qpR python-astropy-0.3-0.1.b1.fc21.x86_64.rpm |grep bin
> /usr/bin/python3
> /usr/bin/xmllint

Yes, I overlooked this. It seems that 'install_scripts' in setup.py overwrites
the shebang if you install the same script from different stacks. Python3
always wins in this case. It should be fixed now.

I have added a new subpackage astropy-tools with the scripts. I will allow to
ease the tranasition from python2 to python3 and from pyfits to astropy.

Spec URL: http://guaix.fis.ucm.es/~spr/python-astropy.spec
SRPM URL: http://guaix.fis.ucm.es/~spr/python-astropy-0.3-0.2.b1.fc20.src.rpm


BTW, this builds in rawhide but not in F20, as python3-configobj hasn't been
pushed to stable yet due to the Beta freeze.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]