[Bug 1026337] Review Request: nfs-ganesha — a user-mode file server for NFS (v3, 4.0, 4.1 pNFS)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1026337



--- Comment #15 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Ooops, parallel build is borked:

[ 65%] [ 65%] make[2]: *** No rule to make target `libntirpc/src/libntirpc.a',
needed by `FSAL/FSAL_PROXY/libfsalproxy.so.4.2.0'.  Stop.

It seems to be a race condition, because it sometimes worked. I removed
%{_smp_flags} to get it to compile.

Build issue aside, I find it hard to justify how including this library doesn't
violate https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries. You said
that "it'll be split out when ready", but actually is seems to be
a totally separate project. I'd approve the package as is, otherwise.

nfs-ganesha.src:62: W: rpm-buildroot-usage %prep %cmake
-DCMAKE_BUILD_TYPE=Maintainer -DBUILD_CONFIG=everything
-DCMAKE_INSTALL_PREFIX=%{buildroot}/usr ./src
Yeah, %cmake step should be moved to %build.

[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/doc/nfs-ganesha-2.0.0
Directory ownership is missing.

Rpmlint (installed packages)
----------------------------
# rpmlint nfs-ganesha nfs-ganesha-docs
nfs-ganesha.x86_64: E: explicit-lib-dependency krb5-libs

Automatic requires should suffice. I get:

libgssapi_krb5.so.2()(64bit)
libgssapi_krb5.so.2(gssapi_krb5_2_MIT)(64bit)
libk5crypto.so.3()(64bit)
libkrb5.so.3()(64bit)
libkrb5.so.3(krb5_3_MIT)(64bit)

Isn't this enough?

Requires
--------
nfs-ganesha (rpmlib, GLIBC filtered):
    ...
    xfsprogs

Why are xfsprogs required?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]