https://bugzilla.redhat.com/show_bug.cgi?id=1026764 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #2 from Christopher Meng <cickumqt@xxxxxxxxx> --- Like ur first package, please use %global instead of %define. Initial thoughts: 1. Remove obsoleted lines for EL5 only: BuildRoot %clean %defattr(-,root,root,-) 2. URL is https://gitorious.org/uhttpmock/. 3. $RPM_BUILD_ROOT/%{_libdir} --> $RPM_BUILD_ROOT%{_libdir} 4. Missing %{?_isa} macro of Requires in -devel subpackage, which actually should be: Requires: %{name}%{?_isa} = %{version}-%{release} 5. Some fields in -devel subpackage is not good. Summary: Header files, libraries and development documentation for %{name} %description devel This package contains the header files, static libraries and development documentation for %{name}. If you like to develop programs using %{name}, you will need to install %{name}-devel. Well I think this is bogus...First there is no static libs, second it's too long... Should be: Summary: Development files for %{name} %description devel This package contains libraries, header files and documentation for developing applications that use %{name}. 6. %{_includedir}/libuhttpmock-0.0 Your package name is uhttpmock, have you made a decision of which name is better, uhttpmock or libuhttpmock? And 0.0 stands for what? 7. Summary: Mocking test utility for HTTP and HTTPS web APIs Isn't it a library? >From pc file: HTTP web service mocking library >From homepage: A HTTP web service mocking library for GNOME Ideas? --------------- I'm not a sponsor, please take a look at: http://fedoraproject.org/wiki/Join_the_package_collection_maintainers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review