[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1023769

Lokesh Mandvekar <lsm5@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lsm5@xxxxxxxxxx



--- Comment #3 from Lokesh Mandvekar <lsm5@xxxxxxxxxx> ---
Hi Peter, Mario:

(In reply to Mario Blättermann from comment #2)


> golang-github-goerlang-dist.spec: I: checking-url
> https://github.com/goerlang/dist/archive/
> 453dec63ea12c128128f9d91b11a82dd570119a0.tar.gz (timeout 10 seconds)
> 2 packages and 1 specfiles checked; 0 errors, 3 warnings.
> 

This might work better for source url:
Source0:
https://%{import_path}/archive/%{commit}/%{realname}-%{shortcommit}.tar.gz
...as in the already existing golang-* packages


> I'm not really happy with the folder ownerships. It seems all your
> golang-github-goerlang-* packages own the folder path
> /usr/share/gocode/src/github.com/goerlang. Well, we have some cases where
> packages may do so, for example for gtk-doc. But in this early state of
> packaging, you could create a dummy package named
> golang-github-goerlang-filesystem which owns this folder. I assume the
> arch-dependent packages in Fedora >=19 and EPEL >=7 use the same folder, so
> there we couldn't get any problems with.

Just to make sure everyone's on the same page, I'm mentioning Matt Miller's
comment here: https://bugzilla.redhat.com/show_bug.cgi?id=1001300#c24 . I guess
if something new gets decided over here, we'll have to make similar changes to
the existing golang-* packages too.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]