https://bugzilla.redhat.com/show_bug.cgi?id=1026337 --- Comment #12 from Kaleb KEITHLEY <kkeithle@xxxxxxxxxx> --- > 1. License is something like "BSD (3 clause) and LGPLv3+", because of libntirpc yes, nfs-ganesha is LGPLv3+, and libntirpc is BSD (as is libtirpc, which it is derived from) > > 2. It would be better to put the docs in /usr/share/doc/nfs-ganesha (not -docs). ??? In the RPMs I have built the docs are in /usr/share/doc/nfs-ganesha-2.0.0/ > > 3. docs package should also have a copy of the LGPLv3+ license. > > 4. Suggestion: change the she-bang line in /usr/bin/genestat.pl to /usr/bin/perl. This will help automatic requires at least. > > 5. Requires: krb5 seems to be unsatisfiable. Is it actually necessary to have anything kerberos-related installed locally? > > 6. systemd service file is missing. > > Something like the attached unit file is a good start. > Please have a look at https://fedoraproject.org/wiki/Packaging:Systemd. > BuildRequires: systemd-units new files at Spec URL: http://kkeithle.fedorapeople.org/update-4/nfs-ganesha.spec SRPM URL: http://kkeithle.fedorapeople.org/update-4/nfs-ganesha-2.0.0-0.rc3.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review