[Bug 1026337] Review Requiest: nfs-ganesha — a user-mode file server for NFS (v3, 4.0, 4.1 pNFS)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1026337



--- Comment #11 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Hm, the package doesn't build in mock --rebuild, but it works if I do mock
--shell and rebuild it by hand there. Maybe a cmake bug? It builds in koji, so
let's ignore that.

1. License is something like "BSD (3 clause) and LGPLv3+", because of libntirpc

2. It would be better to put the docs in /usr/share/doc/nfs-ganesha (not
-docs).

3. docs package should also have a copy of the LGPLv3+ license.

4. Suggestion: change the she-bang line in /usr/bin/genestat.pl to
/usr/bin/perl. This will help automatic requires at least.

5. Requires: krb5 seems to be unsatisfiable. Is it actually necessary to have
anything kerberos-related installed locally?

6. systemd service file is missing.

Something like the attached unit file is a good start.
Please have a look at https://fedoraproject.org/wiki/Packaging:Systemd.
BuildRequires: systemd-units

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]