https://bugzilla.redhat.com/show_bug.cgi?id=1026337 --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- 1. Remove %defattr(-,root,root) 2. Remove rm -rf %{buildroot} 3. Remove %clean 4. Why are libntirpc sources necessary? Shouldn't this be a separate package? 5. It would be nicer to use direct github url as Source0: https://github.com/%{name}/%{name}/archive/pre-2.0-RC2.tar.gz. This way it's easier to update, verify sources, etc. 6. %description could become Summary, and please extend the description a bit, saying a bit more what the project is useful for etc. 8. There's no need to say %{__tar}, %{__rm}, %{__make}, %{__chmod}. Just use plain tar, rm... Such indirection only makes sense for things that are likely to be substituted at some point, like %{__python2}. 9. Please add Provides: bundled(gnulib). 10. Please split out big docs into a separate package (size ~ 2MB). 11. Please change cmake to %cmake. 12. Please change %{__make} to make VERBOSE=1 %{?_smp_mflags}. 13. libzfswrap cannot be bundled (https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries). Please remove it in %prep. Oh, and I think you have a very old fedora-review, which is provided outdated suggestions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review