[Bug 1026042] Review Request: polly - Linux Twitter client designed for multiple columns of multiple accounts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1026042



--- Comment #2 from Michele Baldessari <michele@xxxxxxxxxx> ---
Holy Batman! That was fast ;)

(In reply to Michael Schwendt from comment #1)
> As a quickstart, run "fedora-review -b 1026042" and examine its various
> results.

Ha! Good to know, I was a bit concerned that it did other admin stuff as well.

> > Summary:Linux Twitter client designed for multiple columns
> > of multiple accounts
> Linux, eh? ;-)

Ok ok, I removed it ;)

> > desktop-file-install \
> > …
> > desktop-file-validate 
> 
> Note that desktop-file-install also validates the file, so you only need to
> run either one, not both.

Ack. Removed. 

> > %{_datadir}/icons/*/*/*/*
> 
> If the package doesn't "Requires: hicolor-icon-theme", there are multiple
> unowned directories in the /usr/share/icons/ tree.
> 
>  
> https://fedoraproject.org/wiki/Packaging:
> Guidelines#File_and_Directory_Ownership
>   https://fedoraproject.org/wiki/Packaging:UnownedDirectories

Ah wasn't aware of this. Fixed.

> > %{_datadir}/%{name}/iconsets
> 
> Here the directory %{_datadir}/%{name} is not included.

Fixed as well.

Hohum fedora-review barfs a bit due to the spaces+() in the tarname and the
directory.
I'll look into that and then upload a fresh package.

Thanks for the feedback and regards,
Michele

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]