https://bugzilla.redhat.com/show_bug.cgi?id=1024136 --- Comment #28 from Germán Racca <gracca@xxxxxxxxx> --- (In reply to Michael Schwendt from comment #27) > It's only a misunderstanding. If there hasn't been an update, the original > Spec/SRPM links are still valid. After plenty of comments in the ticket, > that's not so obvious anymore, so reposting them doesn't hurt (albeit is not > mandatory). Sorry for the misunderstanding, now I get it. I will update the spec file as soon as I can implement your suggestions. > [...] > > In the %description: > > > By default this plugin looks for templates in ~/Templates. > > You can change this by editing the source. > > The second sentence is misleading. The installed plugin _is_ a source file, > since it's written in Python. However, editing is not really an option for > RPM package users, because the next update would overwrite the changes. > > The plugin could evaluate XDG_TEMPLATES_DIR. > To avoid any mistake, I think it's better to remove that last sentence (I will suggest upstream the possibility to evaluate XDG_TEMPLATES_DIR). > > # python3 is pulled from gedit dependencies, so no need to install > > explicitly > > Requires: gedit%{?_isa} > > Only one of gedit's current plugins depends on Python 3. Gedit itself does > not. Optimising dependencies is frowned upon. _This_ particular plugin > requires Python 3, so there ought to be a dependency. Not sure if I understand very well here. My logic is: Gedit requires Python 3 (because 'rpm -q --requires gedit' says 'python(abi) = 3.3'), and this plugin requires Gedit. > > $ rpmls -p gedit-template-0.0.2-1.fc19.x86_64.rpm > > -rw-r--r-- /usr/lib64/gedit/plugins/template.plugin > > -rw-r--r-- /usr/lib64/gedit/plugins/template.py > > drwxr-xr-x /usr/share/doc/gedit-template-0.0.2 > > -rw-r--r-- /usr/share/doc/gedit-template-0.0.2/LICENSE > > -rw-r--r-- /usr/share/doc/gedit-template-0.0.2/README > > http://fedoraproject.org/wiki/Packaging:Python#Byte_compiling Byte compiled files are present in my system: rpmls -p gedit-template-0.0.2-1.fc19.x86_64.rpm -rw-r--r-- /usr/lib64/gedit/plugins/template.plugin -rw-r--r-- /usr/lib64/gedit/plugins/template.py -rw-r--r-- /usr/lib64/gedit/plugins/template.pyc -rw-r--r-- /usr/lib64/gedit/plugins/template.pyo drwxr-xr-x /usr/share/doc/gedit-template-0.0.2 -rw-r--r-- /usr/share/doc/gedit-template-0.0.2/LICENSE -rw-r--r-- /usr/share/doc/gedit-template-0.0.2/README Why is that? Thanks for your comments! -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review