[Bug 1018004] Review Request: rubygem-descendants_tracker - Module that adds descendant tracking to a class

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1018004



--- Comment #5 from Ken Dreyer <ktdreyer@xxxxxxxxxxxx> ---
(In reply to Mamoru TASAKA from comment #4)
> * Well, one minor point is that %exclude %doc can simply be %exclude.

Thanks, this was a typo. I'll adjust it before importing.

> * Also, you can simply add %exclude or using rm on %install for Gemfile
>   and etc (instead of modifying gemspec), as you also use %exclude for
>   other files

You're right, maybe I ought to pick one or the other. I'm not keen on having a
gemspec that lists a lot of extra files that the RPM doesn't actually ship, so
I prefer to eliminate the files during %prep. On the other hand, we need the
test suite to be available during %check, so we have to keep that in the
gemspsec that and then %exclude it later. So both options seem to have
disadvantages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]