https://bugzilla.redhat.com/show_bug.cgi?id=929005 Will Benton <willb@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dallen@xxxxxxxxxx Flags| |needinfo?(dallen@xxxxxxxxxx | |) --- Comment #1 from Will Benton <willb@xxxxxxxxxx> --- There are a couple of issues with this package so far: 1. Missing BuildRequires (some of these were given as Requires): git, js, coffee-script, nokogiri, rubygem-git, rubygem-compass, rubygem-compass-960-plugin, rubygem-bootstrap-sass, rubygem-asciidoctor, rubygems-devel, rubygem-coffee-script, rubygem-hashery, rubygem-RedCloth, rubygem-slim, rubygem-redcarpet, rubygem-rdiscount, rubygem-mustache, rubygem-uglifier. 2. spec/config_spec.rb requires both a Rakefile and a Gemfile in order to pass under rpmbuild (it still doesn't pass under mock and I'm trying to figure out why) I've updated the spec with these changes (and a version bump); my revised version is here: https://gist.github.com/willb/7270668. Once you've fixed the test suite running under mock (either by figuring out where it's going wrong or by disabling config_spec.rb), send me an updated spec and I'll resume the review. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review