[Bug 1018004] Review Request: rubygem-descendants_tracker - Module that adds descendant tracking to a class

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1018004



--- Comment #2 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> ---
Except for files list, I have nothing to ask you to modify.
Then:

* Please check if the following files really need being
  packaged in binary rpm:
  - Gemfile
  - Guardfile
  - Rakefile

* spec/ directory and anything below it is usually meant
  to be used only on test suite, and current Ruby guideline
  recommends not to package it:
  ref:
https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Running_test_suites
    notice "Do not ship tests"

* I recommend to move README.md to main package.

? I don't object to including TODO file, however please note
  that currently this file is empty.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]