https://bugzilla.redhat.com/show_bug.cgi?id=1025581 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- Some help(I'm not a sponsor, please find a potential sponsor via: https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group): 1. Please drop these: # # rpm spec for xtrabackup # and ### ### eof ### As far as I can tell you, these are useless and they make the spec jumbled 2. Release: 1 Please read carefully when you want to build a package for Fedora as the first time: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Using_the_.25.7B.3Fdist.7D_Tag 3. http://www.percona.com/redir/downloads/XtraBackup/LATEST/source/percona-xtrabackup-2.1.5.tar.gz --> http://www.percona.com/redir/downloads/XtraBackup/LATEST/source/%{name}-%{version}.tar.gz So next time when you want to update the package, you just need to modify the version tag and it will be changed automatically. 4. Please remove these obsoleted lines for ~EPEL5: BuildRoot: %{_tmppath}/%{name}-%{version}-root [ "%{buildroot}" != '/' ] && rm -rf %{buildroot} %defattr(-,root,root) %clean 5. Please sort your spec in a nice order, in brief, please move %changelog section to the bottom of every spec. 6. I don't know why you had this: %define __os_install_post /usr/lib/rpm/brp-compress I don't think we need it anymore now. 7. install -m 755 Please see: https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps and fix. 8. We don't allow this: AutoReqProv: no Please tell us the reason, we can help. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review