Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-XML-Validator-Schema - Validate XML against a subset of W3C XML Schema https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232622 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-03-23 07:06 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 4f9decc25d2b484df80ee4adfa912f12 XML-Validator-Schema-1.08.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01basic.......ok t/02yaml........ ======> Testing against XML::SAX::PurePerl <====== ======> Testing against XML::LibXML::SAX <====== ok t/03types.......ok t/04model.......ok t/05xerces......skipped all skipped: Test requires $XERCES_DOMCOUNT t/06passthru....skipped all skipped: Test requires XML::SAX::Writer t/07locator.....ok 1/2 skipped: These tests require XML::SAX::ExpatXS All tests successful, 2 tests and 1 subtest skipped. Files=7, Tests=658, 4 wallclock secs ( 2.66 cusr + 0.24 csys = 2.90 CPU) + Provides: perl(XML::Validator::Schema) = 1.08 perl(XML::Validator::Schema::AllModelNode) perl(XML::Validator::Schema::Attribute) perl(XML::Validator::Schema::AttributeLibrary) perl(XML::Validator::Schema::ChoiceModelNode) perl(XML::Validator::Schema::ComplexTypeNode) perl(XML::Validator::Schema::ElementLibrary) perl(XML::Validator::Schema::ElementNode) perl(XML::Validator::Schema::ElementRefNode) perl(XML::Validator::Schema::Library) perl(XML::Validator::Schema::ModelNode) perl(XML::Validator::Schema::Node) perl(XML::Validator::Schema::Parser) perl(XML::Validator::Schema::RootNode) perl(XML::Validator::Schema::SequenceModelNode) perl(XML::Validator::Schema::SimpleType) perl(XML::Validator::Schema::SimpleTypeNode) perl(XML::Validator::Schema::TypeLibrary) perl(XML::Validator::Schema::Util) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review