[Bug 1025367] Review Request: python-requests-oauthlib - OAuthlib authentication support for Requests.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1025367

Pierre-YvesChibon <pingou@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |pingou@xxxxxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Pierre-YvesChibon <pingou@xxxxxxxxxxxx> ---
* Spec is clean
* License is clean and is BSD
* Builds fine on F-19 x86_64
* Content is clean
* Upstream source:
c86bcc7f5773dede54ee1eb6f606313296ee1ad9  requests-oauthlib-0.4.0.tar.gz

* srpm source:
c86bcc7f5773dede54ee1eb6f606313296ee1ad9 
python-requests-oauthlib-0.4.0-1.fc19.src/requests-oauthlib-0.4.0.tar.gz

* No bundling seen

* rpmlint is almost clean
python-requests-oauthlib.noarch: E: explicit-lib-dependency python-oauthlib
python-requests-oauthlib.noarch: W: summary-ended-with-dot C OAuthlib
authentication support for Requests.
python-requests-oauthlib.src: W: summary-ended-with-dot C OAuthlib
authentication support for Requests.
2 packages and 0 specfiles checked; 1 errors, 2 warnings.

You may want to correct this before importing the package

Note: there are no python version supported specified, so you might want to
test it on python 2.6 before considering if you want an epel6 branch or not.

Note2: is the requirements.txt really of interest as a %doc?

Otherwise looks good to me!

This package is APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]