[Bug 1025058] Review Request: python-flask-images - Dynamic image resizing for Flask

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1025058



--- Comment #5 from Eduardo Echeverria <echevemaster@xxxxxxxxx> ---
@Alex 

Some requires are missing

[echevemaster@echevemaster Flask-Images-1.0.0]$ grep -ri "import"
setup.py:from distutils.core import setup
flask_images.py:from __future__ import division
flask_images.py:import math
flask_images.py:import os
flask_images.py:import logging
flask_images.py:from cStringIO import StringIO
flask_images.py:import datetime
flask_images.py:import hashlib
flask_images.py:import sys
flask_images.py:import base64
flask_images.py:import struct
flask_images.py:from urlparse import urlparse
flask_images.py:from urllib2 import urlopen
flask_images.py:from urllib import urlencode
flask_images.py:from subprocess import call
=> flask_images.py:import Image as image (python-pillow since F19 and
python-imaging < F18) 

Can you do this
%if 0%{?fedora} >= 19
Requires:      python-pillow
%else
Requires: python-imaging
%endif


flask_images.py:from flask import request, current_app, send_file, abort
=> flask_images.py:from itsdangerous import Signer, constant_time_compare
(python-itsdangerous)

License field is wrong should be just BSD

- Remove the superflous comments

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]