https://bugzilla.redhat.com/show_bug.cgi?id=1024993 --- Comment #5 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Lukash James from comment #3) > > - Why a manual installation ? > > Does '%make DESTDIR="" install' not work ? > After building lin_guider binary started from build directory. Makefile > haven't 'install' target. > > PS. I am not an upstream developer. Consider to leave a comment in the .spec file to describe the reasons of your choices, above all if they fall outside of packaging guidelines. - You don't need of '%defattr(-, root, root)' line http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions - Please remove the lines #ln -s /opt/gm_software/lin_guider/lg-wrapper.sh $RPM_BUILD_ROOT%{_bindir}/lin_guider #ln -s /opt/gm_software/lin_guider/man/man1/lin_guider.1.gz $RPM_BUILD_ROOT%{_mandir}/man1/lin_guider.1.gz #ln -s /opt/gm_software/lin_guider/man/ru/man1/lin_guider.1.gz $RPM_BUILD_ROOT%{_mandir}/ru/man1/lin_guider.1.gz #install contrib/{mc.sh,mc.csh} $RPM_BUILD_ROOT%{_sysconfdir}/profile.d if they are not necessary. - Your package provides a .desktop file; validate it in a %check section. http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage - Consider that starting from f20, every package docdir subdirectory will be unversioned. See https://fedoraproject.org/wiki/Changes/UnversionedDocdirs -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review