[Bug 1022584] Review Request: qpid-qmf - The QPID Management Framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1022584



--- Comment #11 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
(In reply to Darryl L. Pierce from comment #10)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #9)
> > Please also fix the shebang line on /usr/bin/qmf-gen.
> 
> What should be fixed? It's a standard shebang that uses /usr/bin/env to
> invoke python. There are 13 examples of such alone on my laptop now from
> standard packages, including gnome.
It is considered good style, even if not offical.
I noticed because the package has a requirement on /usr/bin/env
but not /usr/bin/python. Things are just more robust this way,
e.g. the system python is used even if the user installs a private
version.

[1] https://fedoraproject.org/wiki/Script_Interpreters_%28draft%29

> Updated spec:  http://mcpierce.fedorapeople.org/rpms/qpid-qmf.spec
> Updated SRPM: 
> http://mcpierce.fedorapeople.org/rpms/qpid-qmf-0.24-14.fc19.src.rpm
> Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6116090
Let me look it over one more.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]