https://bugzilla.redhat.com/show_bug.cgi?id=187317 --- Comment #44 from Michael Schwendt <bugs.michael@xxxxxxx> --- The rpmlint findings (run rpmlint with option -i for more helpful explanations): > mindi.x86_64: W: only-non-binary-in-usr-lib > mindi.x86_64: E: no-binary False positive, and the spec file comments on that too. It's true that the executables in PATH are only scripts, but the package cannnot be made "noarch" because of the arch-specific %_libdir/mindi/ tree it creates. However, this means the automatically generated -debuginfo package should/could be disabled with this definition: %global debug_package %{nil} Currently, it's empty anyway. > mindi.x86_64: W: dangling-relative-symlink /usr/sbin/parted2fdisk ../../sbin/fdisk > mindi.x86_64: W: dangling-relative-symlink /usr/lib64/mindi/rootfs/sbin/parted2fdisk fdisk Two minor issues here: * It's /usr/sbin/fdisk since Fedora 17: http://fedoraproject.org/wiki/Features/UsrMove * Is the missing dependency on either package "util-linux" or /usr/sbin/fdisk intentional, or has it been optimised away? > mindi.src:42: W: macro-in-comment %{_docdir} In %changelog, please escape macros using double '%%', so they never get expanded. You want to see the macro name in the changelog, not its value, which may change over time. Some macros even can have side-effects when expanding at "wrong" locations of the spec file. > mindi.src:1266: W: mixed-use-of-spaces-and-tabs (spaces: line 1266, tab: line 4) Somewhere deep in the %changelog, so not really an issue. > mindi.src: W: invalid-url Source0: ftp://ftp.mondorescue.org/test/src/mindi-2.1.620130730020540.tar.gz <urlopen error ftp error: [Errno ftp error] 550 Failed to change directory.> Indeed. That tarball is not available in the src download dir. > Release: 0%{dist} Just mentioning, first build for Fedora starts at 1 usually. > %config(noreplace) %{_sysconfdir}/%{name} A bit "sloppy", because this line includes the complete /etc/mindi directory, even README.* files and flags everything as config file. What else? Similar to review of mindi-busybox, being explicit in the spec file with a comment on whether the spec file shall stay compatible with EL5 would be good. Else the old buildroot related cruft may be removed. %defattr usage can be dropped in either case. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review