[Bug 1022584] Review Request: qpid-qmf - The QPID Management Framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1022584



--- Comment #8 from Darryl L. Pierce <dpierce@xxxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #7)
> You didn't reply to the comments about python installation path.
> I still see /usr/lib64/python2.7/site-packages/_cqmf2.so, etc, in
> python-qpid-qmf package. This is really bad, since it puts all those private
> and non-private names in the global python module namespace.

Sorry, totally overlooked that, my bad.

This package review revealed a bug in our installation that I've fixed [1] and
included in this updated package. So the installation for qmfgen is now fixed.

Regarding polluting the global namespace, I'm not sure how that's occurring
with _cqmf2.so being in the root directory for site packages. Since you still
have to specifically import the package, the code within does not wind up in an
unnamed space. Instead, that shared library is loaded by the cqmf2.py file
which requires the library be in the same directory.

Doing the following:

$ sudo yum whatprovides /usr/lib64/python2.7/site-packages/*.so

shows there are many, many other packages that are also deliver shared
libraries in the root directory. So that doesn't seem to be a Bad Thing (tm).
:D

[1] https://issues.apache.org/jira/browse/QPID-5273

Updated spec:  http://mcpierce.fedorapeople.org/rpms/qpid-qmf.spec
Updated SRPM: 
http://mcpierce.fedorapeople.org/rpms/qpid-qmf-0.24-13.fc19.src.rpm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6114003

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]