[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1023769



--- Comment #2 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6114012

$ rpmlint -i -v *golang-github-goerlang-dist.src: I: checking
golang-github-goerlang-dist.src: I: checking-url
https://github.com/goerlang/dist (timeout 10 seconds)
golang-github-goerlang-dist.src:5: W: mixed-use-of-spaces-and-tabs (spaces:
line 5, tab: line 1)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

golang-github-goerlang-dist.src: I: checking-url
https://github.com/goerlang/dist/archive/453dec63ea12c128128f9d91b11a82dd570119a0.tar.gz
(timeout 10 seconds)
golang-github-goerlang-dist-devel.noarch: I: checking
golang-github-goerlang-dist-devel.noarch: W: summary-ended-with-dot C An
implementation of Erlang node.
Summary ends with a dot.

golang-github-goerlang-dist-devel.noarch: I: checking-url
https://github.com/goerlang/dist (timeout 10 seconds)
golang-github-goerlang-dist.spec:5: W: mixed-use-of-spaces-and-tabs (spaces:
line 5, tab: line 1)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

golang-github-goerlang-dist.spec: I: checking-url
https://github.com/goerlang/dist/archive/453dec63ea12c128128f9d91b11a82dd570119a0.tar.gz
(timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 3 warnings.


There's one rather cosmetic problem in your spec file. I suggest to use spaces,
this way the spec file looks the same in all text editors, regardless of the
configured tab width.

I'm not really happy with the folder ownerships. It seems all your
golang-github-goerlang-* packages own the folder path
/usr/share/gocode/src/github.com/goerlang. Well, we have some cases where
packages may do so, for example for gtk-doc. But in this early state of
packaging, you could create a dummy package named
golang-github-goerlang-filesystem which owns this folder. I assume the
arch-dependent packages in Fedora >=19 and EPEL >=7 use the same folder, so
there we couldn't get any problems with.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]