https://bugzilla.redhat.com/show_bug.cgi?id=1022283 --- Comment #35 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- (In reply to Mosaab Alzoubi from comment #31) > ok > > >1. rpmlint: Note: Directories without known owners: /usr/share/gnulib > How to solve ? C'mon, just add /usr/share/gnulib to %files. Actually, if the gnulib requires gnulib-tests, and gnulib-tests require gnulib, there's no point in keeping them separate, so gnulib-tests can go, and then %files is simplified, since everything under /usr/share/gnulib is owned by the main package. > >2. Note: Macros in: gnulib-docs (description) > > Hm, this should be %{name}, not %{gnulib}. I think I added that by mistake. > Done > >3. Requires:java-headless must be added because of the java class > added. > >4. W: invalid-license LGPL2+ > corrected. > > > Are you planning on providing a pre-built git-merge-changelog as a subpackage? > Eric , I think if you write important modules for built as single packages, > that's look nice. Sorry, I can't parse that. > Note new packages called :: > gnulib-%{module} Why not just 'git-merge-changelog'? > >I had no idea about git-merge-changelog. Looks very useful, and I think it > >should definitely be packaged in compiled form. > > Zbigniew , It looks easy just must done before changing (dir) at gnulib-tool. > > For git-merge-changelog just these command (from docs) : > gnulib-tool --create-testdir --dir=%{somedir} git-merge-changelog > cd %{somedir} > configure,make..... Right. Maybe add to %build (only partially tested): ./gnulib-tool --create-testdir --dir=build-g-m-c git-merge-changelog pushd build-g-m-c %configure make %{_smp_mflags} -C gllib git-merge-changelog popd Then there's the question if additional build requirements are needed. Maybe not, since gcc is guaranteed to be present. (In reply to Mosaab Alzoubi from comment #34) > * gnulib-build = copy of gnulib-tool before edited :) I think there's no need to copy, I think. This can be done after the part which creates MODULES.html. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review