Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gmediaserver - UPnP compatible media server for the GNU system Alias: gmediaserver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221906 ------- Additional Comments From bjohnson@xxxxxxxxxxxx 2007-03-23 04:10 EST ------- (In reply to comment #8) > > * %define mediadir /var/gmediaserver > > please read http://www.pathname.com/fhs/pub/fhs-2.3.html and determine the > > proper location... perhaps /var/lib/gmediaserver? > Change to /srv/gmediaserver (consulted on IRC - #fedora-devel) Seems reasonable to me. Init file still needs some work. Here is the relevent rpmlint output: E: gmediaserver wrong-line-in-lsb-tag # gmediaserver Start/stop gmediaserver service E: gmediaserver wrong-line-in-lsb-tag # E: gmediaserver unknow-lsb-tag # chkconfig: - 85 15 E: gmediaserver unknow-lsb-tag # description: GMediaServer is a UPnP compatible media server for the GNU system. It is part \ E: gmediaserver wrong-line-in-lsb-tag # E: gmediaserver unknow-lsb-tag # processname: gmediaserver E: gmediaserver unknow-lsb-tag # config: /etc/sysconfig/gmediaserver E: gmediaserver unknow-lsb-tag # pidfile: /var/run/gmediaserver.pid E: gmediaserver missing-mandatory-lsb-tag Provides E: gmediaserver missing-mandatory-lsb-tag Description E: gmediaserver missing-mandatory-lsb-tag Short-Description And here is an example init with the LSB info: #!/bin/bash # # Startup script for the ntop program # chkconfig: - 81 19 # description: A network traffic probe similar to the UNIX top command # processname: ntop # pidfile: /var/run/ntop.pid # config: /etc/ntop.conf # ### BEGIN INIT INFO # Provides: ntop # Required-Start: $local_fs $network $syslog # Should-Start: # Required-Stop: # Default-Start: 3 4 5 # Default-Stop: 0 1 2 6 # Short-Description: Start ntop daemon # Description: Start ntop, a network traffic probe similar to the UNIX \ # top command ### END INIT INFO E: gmediaserver executable-marked-as-config-file /etc/sysconfig/gmediaserver E: gmediaserver script-without-shebang /etc/sysconfig/gmediaserver this should be installed mode 644 E: gmediaserver executable-marked-as-config-file /etc/logrotate.d/gmediaserver W: gmediaserver spurious-executable-perm /etc/logrotate.d/gmediaserver this should be installed mode 644 > install -D -m755 %{SOURCE1} $RPM_BUILD_ROOT%{_initrddir}/%{name} > cp %{SOURCE1} $RPM_BUILD_ROOT%{_initrddir}/%{name} > chmod +x $RPM_BUILD_ROOT%{_initrddir}/%{name} the install then cp is redundant. use -p to preserve the timestamp. If you want, you can use 'cp -p' or more efficiently: install -D -m 0755 -p %{SOURCE} $RPM_BUILD_ROOT%{_initrddir}/%{name} > install -D $RPM_BUILD_ROOT%{_bindir}/%{name} $RPM_BUILD_ROOT%{_sbindir}/%{name} > rm $RPM_BUILD_ROOT%{_bindir}/%{name} just use 'mv' - it will keep the timestamp, mode, ownership, etc of the original file you might want a comment here too, explaining that the make install put the file in /usr/bin but for a server it should be /usr/sbin/(In reply to comment #8) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review