https://bugzilla.redhat.com/show_bug.cgi?id=1024127 Christopher Meng <cickumqt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cickumqt@xxxxxxxxx --- Comment #1 from Christopher Meng <cickumqt@xxxxxxxxx> --- 1. Remove: # Spec file for LTTV # Above part is useless, we all know it's the spec of LTTV. 2. Where do these manpages come from? Source3: lttv.1 Source4: lttv.real.1 Source5: lttv-gui.1 Any reference? 3. It's better to put URL above the Source(or Source0 if you have diverse sources) 4. Please read: https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description And then change your %description. 5. Instead of writting: %package -n lttv-devel You can just write: %package devel Same in %files 6. I can see $RPM_BUILD_ROOT and ${RPM_BUILD_ROOT} in the spec, well it's not a problem, but I hope you can change them to the same one, $RPM_BUILD_ROOT. Or if you really like braces, change them to %{buildroot} 7. cp command with -a(or -p) option if you preserve the timestamp on your side when fetching it from somewhere. 8. Please leave a blank line of each entry in %changelog, this will help improve the readability. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review