https://bugzilla.redhat.com/show_bug.cgi?id=984560 T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tchollingsworth@xxxxxxxxx --- Comment #5 from T.C. Hollingsworth <tchollingsworth@xxxxxxxxx> --- (In reply to Yajo from comment #4) > New SPEC: > https://build.opensuse.org/package/view_file/home:yajo:enki/enki/enki. > spec?expand=1 HTML again. ;-) -- > %global _iconsbasedir %{?_iconsbasedir:/usr/share/icons/hicolor} > %global _desktopdir %{?_desktopdir:/usr/share/applications} Please don't hardcode /usr. Use the appropriate macro for /usr/share instead: http://fedoraproject.org/wiki/Packaging:RPMMacros > BuildRequires Please add BuildRequires on python2-devel: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires The -devel subpackage makes available certain RPM macros and may enable other magic in the future, so it needs to be explictly BuildRequired from every python spec file. > %{_datarootdir}/pixmaps/%{name}.png Please use %{_datadir} instead. The GNU coding standards explain the subtle distinction between these two: https://www.gnu.org/prep/standards/html_node/Directory-Variables.html -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review