[Bug 1022283] Review Request: gnulib - GNU Portability Library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1022283



--- Comment #24 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Oops, I run fedora-review on this, and there still are issues:

1. "Bundled jar/class files should be removed before build"
There's lib/javaversion.class, which should be recompiled from sources.

%prep
...
rm libs/javaversion.class

%build
...
javac -d lib -source 1.3 -target 1.3 lib/javaversion.java

- Packages have proper BuildRequires/Requires on jpackage-utils
I think R:java-devel is enough.

2. Actually the -docs package also needs R: %{name} = %{version}-%{release}.

It used to be independent, but I missed that MODULES.html links to files in the
base package, so it doesn't make sense to install it alone.

3. Licensing was not described properly according to
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines.

License: Public Domain and BSD and GPLv2+ and GPLv3 and GPLv3+ and LGPLv2 and
LGPL2+ and LGPLv3+

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]