[Bug 996813] Review Request: SQLCipher - Encrypted SQLite databases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=996813

Björn "besser82" Esser <bjoern.esser@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bjoern.esser@xxxxxxxxx



--- Comment #3 from Björn "besser82" Esser <bjoern.esser@xxxxxxxxx> ---
That usually has no affect whether you want to build for EPEL or not.  The
_real_ problem here is:  Your package ships a bundled sqlite-version and that's
something which is strongly discouraged.  See: 
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries

You should actually unbundle `sqlite` and build this against the one shipped by
the system's libs.


BTW. Christopher's question was about the presence of `rm -rf %{buildroot}` on
%install and %check and the presence of Group: and BuildRoot: tags...

Those are simply not needed, but for <= el5.  You can safely drop `defattr`,
because this was needed on <= el4.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]