Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nginx - http and reverse proxy server https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233522 ------- Additional Comments From kevin@xxxxxxxxx 2007-03-22 22:40 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) See below - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 651feea215c9d934542b4bae1711d921 nginx-0.5.15.tar.gz 651feea215c9d934542b4bae1711d921 nginx-0.5.15.tar.gz.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. Not a blocker, just a suggestion, but you might want to change your Source0 line from: Source0: http://sysoev.ru/nginx/nginx-0.5.15.tar.gz to Source0: http://sysoev.ru/nginx/nginx-%{version}.tar.gz So you don't need to change it every release. 2. The upstream calls the license "BSD-Like"... should the License here be "BSD-Like" in the spec? 3. rpmlint says: E: nginx non-standard-uid /var/log/nginx nginx E: nginx non-standard-gid /var/log/nginx nginx E: nginx non-standard-uid /var/lib/nginx nginx E: nginx non-standard-gid /var/lib/nginx nginx Can be ignored. W: nginx strange-permission nginx.init 0775 You might make the init file in the src.rpm mode 644 and then install it with 755 perms? Not a blocker. W: nginx rpm-buildroot-usage %build export DESTDIR=%{buildroot} False positive. E: nginx configure-without-libdir-spec I see that you can't use %configure here, but you might add a comment about having to do so. W: nginx mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 1) Pick tabs or spaces, don't mix. 4. Should the /usr/share/nginx/html be instead marked as %doc? which would put them under /usr/share/doc/nginx-%{version}/ Or does it call those html files from the program? 5. The server doesn't start here after install... I get: 2007/03/22 20:36:50 [emerg] 8189#0: glob() "/usr/share/nginx/conf/mime.types" failed (2: No such file or directory) in /etc/nginx/nginx.conf:18 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review