[Bug 1015868] Review Request: python-qutepart - Source code text editor component based on Qt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1015868



--- Comment #3 from Yajo <yajo.sk8@xxxxxxxxx> ---
Sorry for the delay.

(In reply to T.C. Hollingsworth from comment #1)
> To fix it in this case, just add this to the top of your spec file:
> %global __provides_exclude_from ^%{python_sitearch}/.*\\.so$

Thanks. Fixed. RPM autorequires are like black magic to me. Definitely I need a
sponsor.


(In reply to T.C. Hollingsworth from comment #2)
> Unfortunately, OBS seems to require a login to link to raw content, so you
> might need to use a different hosting provider unless you can resolve that
> somehow (or if I'm just an idiot and can't figure out OBS ;-).

Thanks, someone told me some people did not like OBS-hosted packages. However
you are right.


> I'd also add that anyone with a Fedora account can run scratch builds on our
> Koji buildsystem if they want to.  This explains how it's done:
> https://fedoraproject.org/wiki/
> Join_the_package_collection_maintainers#Install_the_client_tools_.28Koji.
> 29_and_set_up_your_certificate

I'd love it, but I hit bug #977632 when using fedora-packager-setup and another
one when using https://koji.fedoraproject.org/koji/login, so I will use other
method for now. Thanks, however.


> Please use English in spec comments.  (Just to be clear, this doesn't extend
> to the Spanish summary/description, which is done correctly. :-)

Ooops, that comment was deprecated however, since that bug was fixed.


> The README file indicates this is under the LGPLv2.  The original Kate
> sources are under LGPLv2+, however.  Please clarify this with upstream and
> correct the License field in your spec file.

Fixed. However Katepart is under LGPLv2:
https://projects.kde.org/projects/kde/applications/kate/repository/revisions/master/entry/part/README


> Grammar nit:
> "contains port" -> "contains a port"
> 
> You can remove the stuff in parenthesis.

Fixed all those.


> > %build
> > %{__python} setup.py build
> 
> This package contains binary Python extensions, so the distribution compiler
> flags need to be used.  For more information, see:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
> 
> For Python packages, that ends up being something like:
> 
> CFLAGS="%{buildroot}" %{__python} setup.py build

Sorry for that. For what I readed, I think you meant CFLAGS="%{optflags}", and
that's what I put. Correct me if I'm wrong.

Thank you very much. Here are the results:

Spec URL:
https://doc-00-44-docs.googleusercontent.com/docs/securesc/ha0ro937gcuc7l7deffksulhg5h7mbp1/nd26e0pul92ha033si1t9q7mg31jip15/1382731200000/12408635912512098830/*/0B6L4jqW88ytdaDlxNUd2SVFYVjA?h=16653014193614665626&e=download

SRPM URL:
http://download.opensuse.org/repositories/home:/yajo:/enki/Fedora_19/src/python-qutepart-1.1.0-2.1.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]