[Bug 1013485] Re-Review Request: mod_scgi - Apache2 module for the SCGI protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1013485



--- Comment #10 from Dridi Boukelmoune <dridi.boukelmoune@xxxxxxxxx> ---
I've taken a closer look at the latest submission, and I've found the following
issues:

Requires
--------
mod_scgi (rpmlib, GLIBC filtered):
    config(mod_scgi)
    httpd-mmn
    libc.so.6()(64bit)
    rtld(GNU_HASH)

python-scgi (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libpthread.so.0()(64bit)
    libpython2.7.so.1.0()(64bit)
    python(abi)
    rtld(GNU_HASH)

As you can see, autoreq didn't pick python-scgi for the mod_scgi package, so we
need to add one. The httpd-mmn version you're enforcing is missing, I get this
in the build log:
cat: /usr/include/httpd/.mmn: No such file or directory

Other packages use an _httpd_mmn macro [1] but not all of them actually use it
in the Requires tag. This may be a packaging mistake, but I haven't seen
guidelines for httpd modules.

Another issue:
sed -i "1d" $RPM_BUILD_ROOT/%{python_sitearch}/scgi/*

Is it necessary to remove the shebangs ? If the scripts can both be used as
modules and standalone scripts, it's probably best not to remove them.

Everything else looks fine to me.

Best Regards,
Dridi

[1] http://pkgs.fedoraproject.org/cgit/mod_auth_cas.git/tree/mod_auth_cas.spec
   
http://pkgs.fedoraproject.org/cgit/mod_auth_kerb.git/tree/mod_auth_kerb.spec
   
http://pkgs.fedoraproject.org/cgit/mod_auth_openid.git/tree/mod_auth_openid.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]