https://bugzilla.redhat.com/show_bug.cgi?id=1015778 --- Comment #7 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- For -2 * Obsoletes - What I said before is meant that Obsoletes lines must be changed to "Obsoletes: ruby-openid <= 2.1.7-11", for example (i.e. not = but <=) * License tag - Ah, the license tag for the main package should be "Ruby and ASL 2.0 and MIT" (as lib/hmac/hmac.rb, lib/openid/yadis/htmltokenizer.rb are under Ruby). Please update the license tag again, sorry. * Permission - It seems that some files in -doc subpackage have executable permission: /usr/share/gems/gems/ruby-openid-2.3.0/examples/rails_openid/script/rails /usr/share/gems/gems/ruby-openid-2.3.0/examples/discover /usr/share/gems/doc/ruby-openid-2.3.0/rdoc/images/add.png /usr/share/gems/doc/ruby-openid-2.3.0/rdoc/images/arrow_up.png /usr/share/gems/doc/ruby-openid-2.3.0/rdoc/images/delete.png /usr/share/gems/doc/ruby-openid-2.3.0/rdoc/images/tag_blue.png At least it seems wrong that png files have executable permission. * Note that the executable permission on /examples/rails_openid/script/rails, /examples/discover adds the dependency "/usr/bin/env" to -doc subpackage. You may also want to suppress this dependency (by also removing executable permission on these files, or to add filtering macro again (which is contrary to what I said before, however for this case it seems okay) ) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review