[Bug 1021749] Review Request: php-symfony2 - PHP full-stack web framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1021749

Remi Collet <rcollet@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rcollet@xxxxxxxxxx



--- Comment #4 from Remi Collet <rcollet@xxxxxxxxxx> ---
(In reply to Lameire Alexis from comment #3)
> On the test section, you must add this peace of code into new source.

?

> Yes, the failing PHPUnit tests are normal unfortunately.
> They fail even when I manually run the tests on all of my test machines.
>  I added "|| : Temporarily ignore failed tests" in the %check section so
> the failing PHPUnit tests do not cause the building of the RPMs to fail though.

I a bit uncomfortable with completely skipping the test result.

In previous multi-spec solution, the test of most of the component were ok.
Only a few were ignored.

Skipping the test global result will not allow us to detect regression.

I should be possible to disable "only" the failed test ?
(during investigation with upstream on those failure)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]