[Bug 1023210] Review Request: irawadi-user - Python Library for manage system user in Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1023210

Yohan Graterol <yohangraterol92@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |yohangraterol92@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |yohangraterol92@xxxxxxxxx



--- Comment #4 from Yohan Graterol <yohangraterol92@xxxxxxxxx> ---
Hello Rino,

You can use variables with the macro %global variable_name value, in the case
you need add a variable for use in all spec.

Example %global package_name irawadi-user, with that variable is not necessary
add the package name in Source0, %prep. etc.

> https://github.com/yograterol/%{package_name}/archive/%{commit}/%{package_name}-%{version}-%{shortcommit}.tar.gz

Anyway, is not necessary for the package. But, you know for the future.

Please:

1 - Remove the comment "# For arch-specific packages: sitearch"
2 - %{__python} is deprecated. You should use %{__python2} or %{__python3} as
the case. [0]

[0] http://fedoraproject.org/wiki/Packaging:Python#Macros

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]