https://bugzilla.redhat.com/show_bug.cgi?id=1015958 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx --- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- 1. Please use %{commit} for the sha1. 2. Please use http://repo.or.cz/w/%{name}.git/snapshot/%{commit}.tar.gz for Source0 and remove snapshot.sh. 3. Can you extend the %description a bit: for people who know very little about audio (like your reviewer :)), a hint what is VST would be helpful. Also, this package seems to be a library (because it has a -devel counterpart), but also a tool, since it is used to "run" things. 4. Use 'make CFLAGS=...' not 'CFLAGS=... make'. 5. Use 'make %{?_smp_mflags} ...', unless parallel build is not supported, in which case add a note. 6. Are those explicit permissions necessary? I'm pretty sure that plain 'mkdir -p' for dirs and 'cp -p' for files should work. 7. Doesn't build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6096872 ;( -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review