https://bugzilla.redhat.com/show_bug.cgi?id=973069 --- Comment #18 from Simone Caronni <negativo17@xxxxxxxxx> --- Issues: > [!]: If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %doc. > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. No licenses > found. Please check the source files for licenses manually. > [!]: If the source package does not include license text(s) as a separate file > from upstream, the packager SHOULD query upstream to include it. > [!]: Package does not include license text files separate from upstream. The license is MIT, but there's no license file installed. Please provide one in %doc. > [!]: Package consistently uses macros (instead of hard-coded directory names). On line 33, please use %{_datadir} instead of /usr/share. On line 47 and 48 please use %{_sharedstatedir} instead of /var/lib. > [!]: SourceX tarball generation or download is documented. > [!]: SourceX is a working URL. > [!]: Spec file according to URL is the same as in SRPM. > Note: 0 or more than one spec file in srpm(!) > See: (this test has no URL) There is no documentation nor procedure on how to regenerate the source tarball. Please provide an external script in the source (like Mesa) or provide comments in the SPEC file. Also the versioning needs documenting, where does 0.9.4.183.g644e24e.428 come from? I assume it's a snapshot, so if you paste commands to regenerate the tarball that would be ok. I assume you can move the URL to Source0, etc. > Group: Development/Tools Please remove the Group tag, is needed only on EPEL 5. > %description Please make the first description line a bit longer so that it goes nearer to the 80 columns limit. > Package does not contain duplicates in %files. > Note: warning: File listed twice: /var/lib/lpf/packages/spotify-client/state > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles You can remove line 48; line 47 already includes everything beneath the directory listed. To make it list only one directory (so you can keep line 48) please use the %dir macro which only adds the directory and not the contents. Rpmlint issues: > lpf-spotify-client.noarch: W: invalid-url > URL: http://leamas.fedorapeople.org/spotify/0.9.0/lpf-spotify-client.spec > HTTP Error 404: Not Found Please fix, see above comment for source. All the other warnings do not apply here so packages are ok. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review