https://bugzilla.redhat.com/show_bug.cgi?id=1021721 --- Comment #12 from Erik Johnson <erik@xxxxxxxxxxxxx> --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #11) > (In reply to Erik Johnson from comment #10) > > (In reply to Zbigniew Jędrzejewski-Szmek from comment #9) > > > Group: → not necessary > > > > > > > At all, or is it still necessary for EPEL5? > EPEL5 needs it, I think. > > > > cd $RPM_BUILD_DIR/%{_realname}-%{version} → not necessary > > > > > > > Ah, so there is an implicit cd to the directory where the source was > > unpacked (at least, in single-source builds)? > Yes. At the beginning of every section like %prep, %build, etc. > > > > Since you are also upstream for salttesting (judging by the email address): > > > don't use bare 'except:' ever: it catches ^C. Not necessary, but it would be > > > nice to fix. > > > > > > > Yeah, I haven't done any work with the test framework per se, I do most of > > my work on salt proper. I did however just submit a pull request to get > > those bare excepts changed (at least temporarily) to "except Exception". > > > > > And also, can you include a license file upstream? > > > > > > > I brought up this point with the guy that manages the salt-testing project, > > and by the end of this week we expect a 0.5.2 release to be cut, which will > > include a LICENSE file. > Great. > > > > setup.py says Python 3 is alpha state... Are there any plans for full > > > support? (See https://fedoraproject.org/wiki/Changes/Python_3_as_Default). > > > > > > Looks nice and clear. > > > > Full support for Python 3 is expected in the next several months, M2Crypto > > is still required to run salt and is the only real blocker, until we can > > move to ZeroMQ 4 which includes its own crypto. > Good. > > Can you submit an updated spec file? We can finish the review without > waiting for the release... Done, here are the updated files. Spec URL (non-EL5): https://dl.dropboxusercontent.com/s/lajrklwy1g2alcm/python-salttesting.spec Spec URL (EL5 only): https://dl.dropboxusercontent.com/s/etioz6yt3zt1pkt/python-salttesting.el5.spec SRPM URL: https://dl.dropboxusercontent.com/s/civx46salq1hv2z/python-salttesting-0.5.1-3.el6.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review