Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gmediaserver - UPnP compatible media server for the GNU system Alias: gmediaserver https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221906 ------- Additional Comments From bjohnson@xxxxxxxxxxxx 2007-03-22 13:06 EST ------- Ok, then, let's get started. I'll break up my findings into multiple replies. It should be a little easier to digest this way. Obvious problems: * init file uses daemon function from initscripts but does not require initscripts * package can not assign static uid unless it's registered at this uid: /usr/sbin/fedora-groupadd -r gmediaserver -u 105 &>/dev/null || : /usr/sbin/useradd -c "gmediaserver" -u 105 \ * scriptlet used chkconfig but does not require it Requires(post): /sbin/chkconfig Requires(preun): /sbin/chkconfig same with /sbin/service, but since you will have to include initscripts anyway you will not need that. * please create backup patch files, ie: %patch0 -p0 -b .mypatch * please use install to perform this. specifically, you will want to look at the -m (mode), -d (directory), -p (preserve timestamp), and -D (create leading components): mkdir -p $RPM_BUILD_ROOT%{_initrddir} cp %{SOURCE1} $RPM_BUILD_ROOT%{_initrddir}/%{name} chmod +x $RPM_BUILD_ROOT%{_initrddir}/%{name} * %define mediadir /var/gmediaserver please read http://www.pathname.com/fhs/pub/fhs-2.3.html and determine the proper location... perhaps /var/lib/gmediaserver? * please use the correct macro for /var. You can find any macros you need with 'rpm --showrc | grep /var'. In this case, it's %{_localstatedir}: /var/log/%{name} * package used logrotate.d directory but does not require logrotate: %config(noreplace) %{_sysconfdir}/logrotate.d/%{name} * rpmlint is confused by your init file. this is a bug in rpmlint though. do you need to allow overrides for some of your variables: pidfile=${PIDFILE-/var/run/gmediaserver.pid} lockfile=${LOCKFILE-/var/lock/subsys/gmediaserver} these should never change and would probably be better static unless you have a good reason * please consider adding the LSB bits (BEGING INIT INFO, END INIT INFO) to your init file: http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html * mixing fedora-groupadd / groupadd. Decide on one or the other. If you want to use fedora-usermgmt, you must also put in the proper requires: http://fedoraproject.org/wiki/PackageUserCreation * chown in scriptlets: set the uid/gid/mode in the %files section If you have questions or comments about any of these, please let me know. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review