https://bugzilla.redhat.com/show_bug.cgi?id=1021733 --- Comment #5 from Christopher Meng <cickumqt@xxxxxxxxx> --- (In reply to Björn "besser82" Esser from comment #4) > [!]: License file installed when any subpackage combination is installed. > > ---> License is missing in -doc. The -doc sub-pkg should have > `%doc changelog LICENSE README build/sphinx/html` (without that > '/*' suffixed) instead of `%doc build/sphinx/html/*`. So it > will pick-up all docs && carry a html-subdir. I'm sorry, but I don't agree. I think doc package should only contains docs, but no need to ship changelog LICENSE README anymore. Besides I think keeping /* will let users enter the dir and see docs immediately but not enter a html folder again. > [!]: %check is present and all tests pass. > > ---> there is a tests-subdir in tarball. You should BR: > python-nose, python3-nose and run the corresponding > `nosetests` within %check. Because tests will fail to test. 1. Simply use nosetests-%{python_version} Failed because ImportError: No module named secretstorage 2. Then I did a tricks: PYTHONPATH=%{buildroot}%{python_sitelib} nosetests-%{python_version} This time real failures are coming: --------------------------- Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.NGiSNR + umask 022 + cd /home/rpmaker/rpmbuild/BUILD + cd SecretStorage-1.0.0 + pushd tests ~/rpmbuild/BUILD/SecretStorage-1.0.0/tests ~/rpmbuild/BUILD/SecretStorage-1.0.0 + PYTHONPATH=/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages + nosetests-2.7 ..EEEE..E ====================================================================== ERROR: test_create_empty_item (test_collection.CollectionTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/rpmaker/rpmbuild/BUILD/SecretStorage-1.0.0/tests/test_collection.py", line 28, in test_create_empty_item item = self.collection.create_item('', {}, b'') File "/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/collection.py", line 120, in create_item self.ensure_not_locked() File "/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/collection.py", line 55, in ensure_not_locked raise LockedException('Collection is locked!') LockedException: Collection is locked! ====================================================================== ERROR: test_label (test_collection.CollectionTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/rpmaker/rpmbuild/BUILD/SecretStorage-1.0.0/tests/test_collection.py", line 33, in test_label self.collection.set_label('Hello!') File "/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/collection.py", line 109, in set_label self.ensure_not_locked() File "/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/collection.py", line 55, in ensure_not_locked raise LockedException('Collection is locked!') LockedException: Collection is locked! ====================================================================== ERROR: test suite for <class 'test_compat_functions.CompatFunctionsTest'> ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/nose/suite.py", line 208, in run self.setUp() File "/usr/lib/python2.7/site-packages/nose/suite.py", line 291, in setUp self.setupContext(ancestor) File "/usr/lib/python2.7/site-packages/nose/suite.py", line 314, in setupContext try_run(context, names) File "/usr/lib/python2.7/site-packages/nose/util.py", line 469, in try_run return func() File "/home/rpmaker/rpmbuild/BUILD/SecretStorage-1.0.0/tests/test_compat_functions.py", line 23, in setUpClass ATTRIBUTES, PASSWORD) File "/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/__init__.py", line 96, in create_item collection.unlock() File "/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/collection.py", line 70, in unlock return exec_prompt_glib(self.bus, prompt)[0] File "/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/util.py", line 85, in exec_prompt_glib exec_prompt(bus, prompt, callback) File "/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/util.py", line 73, in exec_prompt prompt_iface.connect_to_signal('Completed', new_callback) File "/usr/lib/python2.7/site-packages/dbus/proxies.py", line 544, in connect_to_signal dbus_interface, **keywords) File "/usr/lib/python2.7/site-packages/dbus/proxies.py", line 369, in connect_to_signal **keywords) File "/usr/lib/python2.7/site-packages/dbus/bus.py", line 148, in add_signal_receiver path, **keywords) File "/usr/lib/python2.7/site-packages/dbus/connection.py", line 400, in add_signal_receiver self._require_main_loop() RuntimeError: To make asynchronous calls, receive signals or export objects, D-Bus connections must be attached to a main loop by passing mainloop=... to the constructor or calling dbus.set_default_main_loop(...) ====================================================================== ERROR: test_double_deleting (test_exceptions.ExceptionsTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/rpmaker/rpmbuild/BUILD/SecretStorage-1.0.0/tests/test_exceptions.py", line 22, in test_double_deleting {'application': 'secretstorage-test'}, b'pa$$word') File "/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/collection.py", line 120, in create_item self.ensure_not_locked() File "/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/collection.py", line 55, in ensure_not_locked raise LockedException('Collection is locked!') LockedException: Collection is locked! ====================================================================== ERROR: test suite for <class 'test_item.ItemTest'> ---------------------------------------------------------------------- Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/nose/suite.py", line 208, in run self.setUp() File "/usr/lib/python2.7/site-packages/nose/suite.py", line 291, in setUp self.setupContext(ancestor) File "/usr/lib/python2.7/site-packages/nose/suite.py", line 314, in setupContext try_run(context, names) File "/usr/lib/python2.7/site-packages/nose/util.py", line 469, in try_run return func() File "/home/rpmaker/rpmbuild/BUILD/SecretStorage-1.0.0/tests/test_item.py", line 24, in setUpClass b'pa$$word') File "/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/collection.py", line 120, in create_item self.ensure_not_locked() File "/home/rpmaker/rpmbuild/BUILDROOT/python-SecretStorage-1.0.0-1.fc21.i386/usr/lib/python2.7/site-packages/secretstorage/collection.py", line 55, in ensure_not_locked raise LockedException('Collection is locked!') LockedException: Collection is locked! ---------------------------------------------------------------------- Ran 7 tests in 0.893s FAILED (errors=5) error: Bad exit status from /var/tmp/rpm-tmp.NGiSNR (%check) ---------------------------------------------------------------------- Also my computer's keyring unlock window bumped out and asked my password. So I didn't add tests. > ===== Additional comments ===== > > - There is trouble when building the autodocs with sphinx, because of missing > BR: dbus-python. You should add that. Fixed. I will listen to your new opinions and then upload a new version. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review