[Bug 1021721] Review Request: python-salttesting - Testing library for SaltStack projects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1021721



--- Comment #4 from Erik Johnson <erik@xxxxxxxxxxxxx> ---
(In reply to Mario Blättermann from comment #1)
> Your package bundles a prebuilt egg, please remove it before building the
> package:
> rm -rf %{_realname}.egg-info
> See http://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs.
> 

Done, I added these lines to the %build step. Links from the initial posts
should be updated with the new specs and SRPM.

> The Python macros have been changed recently to be more future-proof:
> https://fedoraproject.org/wiki/Packaging:Python#Macros
> %{__python} --> %{__python2}
> Moreover, %{python_sitelib} should be %{python2_sitelib} although this is
> not mentioned in the guidelines. For EPEL6 try to run the following command
> to see if it is also available there:
> $ rpm --eval %{python2_sitelib}
> 

erik@virtucentos:~% cat /etc/redhat-release
CentOS release 6.4 (Final)
erik@virtucentos:~% rpm --eval %{python2_sitelib}
%{python2_sitelib}
erik@virtucentos:~% rpm --eval %{python_sitelib}
/usr/lib/python2.6/site-packages
erik@virtucentos:~% rpm --eval %{__python2}
%{__python2}
erik@virtucentos:~% rpm --eval %{__python}
/usr/bin/python

I did this both before and after running updates on my build VM as I hadn't
intalled any updates in a while, and I got the same result.


I also added the BuildRequires as recommended by Johan.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]