[Bug 1021721] Review Request: python-salttesting - Testing library for SaltStack projects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1021721

Mario Blättermann <mario.blaettermann@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mario.blaettermann@xxxxxxxx
                   |                            |m



--- Comment #1 from Mario Blättermann <mario.blaettermann@xxxxxxxxx> ---
Your package bundles a prebuilt egg, please remove it before building the
package:
rm -rf %{_realname}.egg-info
See http://fedoraproject.org/wiki/Packaging:Python_Eggs#Upstream_Eggs.

The Python macros have been changed recently to be more future-proof:
https://fedoraproject.org/wiki/Packaging:Python#Macros
%{__python} --> %{__python2}
Moreover, %{python_sitelib} should be %{python2_sitelib} although this is not
mentioned in the guidelines. For EPEL6 try to run the following command to see
if it is also available there:
$ rpm --eval %{python2_sitelib}

(In reply to Erik Johnson from comment #0)
> Note that I have included two spec files in this review request, one without
> the lines which are unnecessary for non-EL5 builds, and one that will be
> used for EL5 only.
> 
Perfectly! This way we don't have to entrain all the obsolete definitions and
conditions through the newer EPEL and Fedora releases.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]