Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: g3data - Program for extracting the data from scanned graphs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232752 wolfy@xxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wolfy@xxxxxxxxxxxxxxxxxx Flag| |fedora-review+ ------- Additional Comments From wolfy@xxxxxxxxxxxxxxxxxx 2007-03-22 11:49 EST ------- GOOD: - no output from rpmlint checks (on source or binary) - package meets naming guidelines - package meets packaging guidelines - license (GPL ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream, is latest available version, sha1sum 033184423798d1d8f192b9c211fba0ec50c47a95 g3data-1.5.1.tar.gz - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - no libtool/pkconfig/static files owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - program is a GUI, properly installs a .desktop file SHOULD - compiles and build happily in mock /FC6 and devel/X86_64 - works as advertised I see no blockers so package is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review