https://bugzilla.redhat.com/show_bug.cgi?id=1013037 --- Comment #4 from Orion Poplawski <orion@xxxxxxxxxxxxx> --- (In reply to Jerry James from comment #3) > I will take this review. > > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > > Issues: > ======= > - Package contains BR: python2-devel or python3-devel Added. > - Large documentation must go in a -doc subpackage. Large could be size > (~1MB) > or number of files. > Note: Documentation size is 10557440 bytes in 163 files. > See: > http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation > > This warning is because the documentation ends up in BOTH the main package > and the -doc subpackage. You will need to add %exclude lines to both the > main %files and %files doc to make sure each file goes into only one of the > two packages. Oops, fixed. > - This is extremely minor, but the jinja patch applies with offsets: > > patching file Makefile.in > Hunk #3 succeeded at 1209 (offset 48 lines). > Hunk #4 succeeded at 1262 (offset 48 lines). > > and there is also a typo in the %patch0 application: jijna2 -> jinja2 Good catch, rebased. > - On the subject of bundled libraries, I see that you removed jinja2, but > what > about the rest of the code under vendor/common? What is its status? That is all common upstream configuration files for their projects. Used for building. > - Should jinja2 be a Requires? Yes, added. > - I am confused by the python code. It is only present in the -devel > package. > I don't know what it does, so this is probably just my ignorance speaking, > but are you sure it is never needed at runtime? Used by otf2-template, moved to base package. > - There is no Requires on an appropriate python abi. See > https://fedoraproject.org/wiki/Packaging:Python#Multiple_Python_Runtimes Added requires python-jinja2 should handle this I believe now. > - There is no BR on an appropriate version of python-devel. See > https://fedoraproject.org/wiki/Packaging:Python#BuildRequires As above. > - Consider adding a %check script Upstream told me the magic incantation need to enable the tests. Added. Spec URL: http://www.cora.nwra.com/~orion/fedora/otf2.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/otf2-1.2.1-3.fc19.src.rpm * Mon Oct 21 2013 Orion Poplawski <orion@xxxxxxxxxxxxx> - 1.2.1-3 - Add BR python2-devel - Add Requires jinja2 - Exclude docs from main package - Rebase jinja2 patch -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review