[Bug 1020088] Review Request: blosc - A high performance compressor optimized for binary data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1020088



--- Comment #17 from Ralf Corsepius <rc040203@xxxxxxxxxx> ---
(In reply to Thibault North from comment #15)
> This seems to fix both issues (tested on f19 and f20):
Yes, much better now!

However, checking *-8, I just noticed another issue:

* Compilation doesn't honor %optflags:
...
cd /builddir/build/BUILD/blosc-1.2.3/tests && /usr/bin/cmake -E
cmake_link_script CMakeFiles/test_basics.dir/link.txt --verbose=1
/usr/lib/ccache/cc  -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions
-fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches  -m32
-march=i686 -mtune=atom -fasynchronous-unwind-tables -O3 -DNDEBUG   
CMakeFiles/test_basics.dir/test_basics.c.o  -o test_basics 
-L/builddir/build/BUILD/blosc-1.2.3/blosc -rdynamic ../blosc/libblosc.so.1.2.3
-lpthread -Wl,-rpath,/builddir/build/BUILD/blosc-1.2.3/blosc
...

Note: There is a -O3 overriding the -O2 from %optflags.

I am far from being a cmake specialist, but AFAICT, one fix to this would be
using %cmake instead of the cmake-%if-cascade:

%cmake \
     -DBUILD_STATIC:BOOL=OFF \
     -DTEST_INCLUDE_BENCH_SUITE:BOOL=OFF .


Finally, %_pkgdocdir meanwhile is available in all releases of Fedoras. 
I.e. you plan to support EPEL you could also remove %{!?_pkgdocdir:...}.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]