[Bug 1013485] Re-Review Request: mod_scgi - Python implementation of the SCGI protocol

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1013485



--- Comment #6 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
(In reply to Dridi Boukelmoune from comment #5)
> You've removed the bundled passfd, but I don't see any alternative. The
> package should require something that would provide passfd. Since I don't
> find any, this spec should build both the mod_scgi and python-passfd
> package, shouldn't it ?
> 
> OTOH, /usr/lib64/python2.7/site-packages/scgi/scgi_server.py does
> ```
> from scgi import passfd
> ```
> 
> Is it really bundled then, other packages seem to do the same thing ? Sorry
> about that, the rest of the package looks good (still needs a closer look).

I looked this up. I found a python-passfd[1], but it's quite different from the
implementation provided in scgi. I'd say that scgi is using a specific
implementation of passfd(pass file descriptor), and this should be included as
an internal library, not one that other applications are supposed to use. 

I think I should build it, include it in the same package (since we don't want
yum finding a python-passfd package), but filter it from requires, since it's
only to be used by the python scripts in this package. Does that sound OK
Dridi?

Thanks,
Ankur

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]