https://bugzilla.redhat.com/show_bug.cgi?id=979767 --- Comment #10 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to Christopher Meng from comment #8) > No, you are doing something wrong: > > %dir %{_datadir}/icons/hicolor/ > %dir %{_datadir}/icons/hicolor/16x16/ > %dir %{_datadir}/icons/hicolor/16x16/apps/ > %dir %{_datadir}/icons/hicolor/22x22/ > %dir %{_datadir}/icons/hicolor/22x22/apps/ > %dir %{_datadir}/icons/hicolor/24x24/ > %dir %{_datadir}/icons/hicolor/24x24/apps/ > %dir %{_datadir}/icons/hicolor/32x32/ > %dir %{_datadir}/icons/hicolor/32x32/apps/ > %dir %{_datadir}/icons/hicolor/48x48/ > %dir %{_datadir}/icons/hicolor/48x48/apps/ > %dir %{_datadir}/icons/hicolor/64x64/ > %dir %{_datadir}/icons/hicolor/64x64/apps/ > %dir %{_datadir}/icons/hicolor/128x128/ > %dir %{_datadir}/icons/hicolor/128x128/apps/ > %dir %{_datadir}/icons/hicolor/256x256/ > %dir %{_datadir}/icons/hicolor/256x256/apps/ > %dir %{_datadir}/icons/hicolor/scalable/ > %dir %{_datadir}/icons/hicolor/scalable/apps/ > > These dirs are used by other pkgs, too: > > [ ]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: > /usr/share/icons/hicolor/256x256/apps(hicolor-icon-theme, fedora-logos), > /usr/share/icons/hicolor/24x24(hicolor-icon-theme, fedora-logos), > /usr/share/icons/hicolor/64x64/apps(hicolor-icon-theme), > /usr/share/icons/hicolor/22x22(hicolor-icon-theme, fedora-logos), > /usr/share/icons/hicolor/48x48/apps(hicolor-icon-theme, fedora-logos, > metromap), /usr/share/icons/hicolor/22x22/apps(hicolor-icon-theme, > fedora-logos), /usr/share/icons/hicolor/32x32/apps(hicolor-icon-theme, > fedora-logos), /usr/share/icons/hicolor/48x48(hicolor-icon-theme, > fedora- > logos), /usr/share/icons/hicolor/24x24/apps(hicolor-icon-theme, fedora- > logos), /usr/share/icons/hicolor/16x16/apps(hicolor-icon-theme, fedora- > logos), /usr/share/icons/hicolor/scalable/apps(hicolor-icon-theme, > fedora-logos), /usr/share/icons/hicolor/16x16(hicolor-icon-theme, > fedora- > logos), /usr/share/icons/hicolor/128x128/apps(hicolor-icon-theme), > /usr/share/icons/hicolor/128x128(hicolor-icon-theme), > /usr/share/icons/hicolor/64x64(hicolor-icon-theme), /usr/share/appdata > (gnome-color-manager, ghex, baobab, gnome-contacts, gnome-calculator, > gnome-documents, epiphany, gnome-system-monitor, simple-scan, gedit, > filesystem, gnome-boxes), /usr/share/icons/hicolor/256x256(hicolor-icon- > theme, fedora-logos), /usr/share/icons/hicolor(hicolor-icon-theme, > fedora-logos), /usr/share/icons/hicolor/32x32(hicolor-icon-theme, > fedora- > logos), /usr/share/icons/hicolor/scalable(hicolor-icon-theme, fedora- > logos) > > My opinion is that you should keep original list but only add these two: > > /usr/share/kapow, /usr/share/kapow/translations > > to be owned. I'm slightly confused about this. I checked up the guidelines: It's OK to co-own packages if the functionality of this package doesn't depend on the other packages owning the same directories. I haven't been able to figure out if kapow will pull in fedora-logos or hicolor in the dep chain. (This is also probably why both fedora-logos and hicolor own the directories, since they aren't dependent on each other) https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function I double checked with my other specs, and yes, they don't own these directories. I'll remove them before import. I'll get this clarified for my own understanding later on though. > > Please fix issues above before import. > > ----------- > > PACKAGE APPROVED. (In reply to Christopher Meng from comment #9) > Forgot to say: > > Use macro to ldflags: > > export LDFLAGS="%{__global_ldflags}" Fixed. Thank you for the review. Warm regards, Ankur -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review