https://bugzilla.redhat.com/show_bug.cgi?id=1018489 Johan Swensson <kupo@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kupo@xxxxxxx --- Comment #4 from Johan Swensson <kupo@xxxxxxx> --- * License tag is invalid. * Documentation is not put in the correct place. Take a look at the %doc macro. * Package contains prepackaged jar-files: http://fedoraproject.org/wiki/Packaging:Java#Pre-built_JAR_files_.2F_Other_bundled_software * Use a correct Source URL http://fedoraproject.org/wiki/Packaging:SourceURL * Upstream url seems invalid, it should probably be http://griffon.codehaus.org and not http://www.grails.org I'm afraid this package is gonna need some work. These are just some starting points. Rpmlint ------- Checking: griffon-1.4.0-1.fc19.noarch.rpm griffon-1.4.0-1.fc19.src.rpm griffon.noarch: E: devel-dependency java-devel griffon.noarch: W: no-version-in-last-changelog griffon.noarch: W: invalid-license Apache 2.0 griffon.noarch: W: no-documentation griffon.noarch: E: zero-length /usr/share/griffon/samples/GroovyEdit/griffon-app/i18n/messages.properties griffon.noarch: E: zero-length /usr/share/griffon/samples/Greet/griffon-app/lifecycle/Stop.groovy griffon.noarch: E: zero-length /usr/share/griffon/samples/WeatherWidget/griffon-app/lifecycle/Shutdown.groovy griffon.noarch: E: script-without-shebang /usr/share/griffon/samples/Greet/griffon-app/services/greet/MicroblogService.groovy griffon.noarch: E: zero-length /usr/share/griffon/samples/WeatherWidget/griffon-app/lifecycle/Ready.groovy griffon.noarch: E: zero-length /usr/share/griffon/samples/WeatherWidget/griffon-app/i18n/messages.properties griffon.noarch: E: zero-length /usr/share/griffon/samples/FontPicker/griffon-app/lifecycle/Ready.groovy griffon.noarch: E: script-without-shebang /usr/share/griffon/bin/griffonsh.bat griffon.noarch: E: wrong-script-end-of-line-encoding /usr/share/griffon/bin/griffonsh.bat griffon.noarch: E: script-without-shebang /usr/share/griffon/bin/startGriffon griffon.noarch: E: zero-length /usr/share/griffon/samples/FileViewer/griffon-app/lifecycle/Stop.groovy griffon.noarch: E: zero-length /usr/share/griffon/samples/FontPicker/griffon-app/lifecycle/Stop.groovy griffon.noarch: E: zero-length /usr/share/griffon/samples/WeatherWidget/griffon-app/lifecycle/Startup.groovy griffon.noarch: E: script-without-shebang /usr/share/griffon/bin/griffon-debug.bat griffon.noarch: E: zero-length /usr/share/griffon/samples/WeatherWidget/griffon-app/lifecycle/Stop.groovy griffon.noarch: E: script-without-shebang /usr/share/griffon/bin/startGriffon.bat griffon.noarch: E: wrong-script-end-of-line-encoding /usr/share/griffon/bin/startGriffon.bat griffon.noarch: E: zero-length /usr/share/griffon/samples/FileViewer/griffon-app/i18n/messages.properties griffon.noarch: E: script-without-shebang /usr/share/griffon/bin/griffon.bat griffon.noarch: E: wrong-script-end-of-line-encoding /usr/share/griffon/bin/griffon.bat griffon.noarch: E: zero-length /usr/share/griffon/samples/Greet/griffon-app/lifecycle/Shutdown.groovy griffon.noarch: E: zero-length /usr/share/griffon/samples/Greet/griffon-app/lifecycle/Startup.groovy griffon.noarch: E: zero-length /usr/share/griffon/samples/Greet/griffon-app/i18n/messages.properties griffon.noarch: E: script-without-shebang /usr/share/griffon/samples/Greet/test/unit/MicroblogServiceTests.groovy griffon.noarch: E: zero-length /usr/share/griffon/samples/FontPicker/griffon-app/lifecycle/Shutdown.groovy griffon.noarch: E: zero-length /usr/share/griffon/samples/FontPicker/griffon-app/i18n/messages.properties griffon.noarch: W: empty-%post griffon.noarch: W: class-path-in-manifest /usr/share/griffon/lib/itext-2.0.8.jar griffon.noarch: W: class-path-in-manifest /usr/share/griffon/lib/radeox-1.0-b2.jar griffon.src: W: no-version-in-last-changelog griffon.src: W: invalid-license Apache 2.0 griffon.src: W: invalid-url Source0: griffon-1.4.0-src.tgz 2 packages and 0 specfiles checked; 27 errors, 9 warnings. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review