https://bugzilla.redhat.com/show_bug.cgi?id=1019770 --- Comment #2 from Michael Schwendt <bugs.michael@xxxxxxx> --- Right. [...] The file at "Spec URL" and the spec file in the src.rpm are not the same. The diff is: -%{lualibdir}/term/core.so +%attr(644, -, -) %{lualibdir}/term/core.so The %changelog ought to have mentioned that. ;) So far, we keep shared libs executable, since that's a requirement for the automatic -debuginfo generation and stripping done by rpmbuild. We must not turn them -x in %install. Setting them to -x via %attr works _currently_, because apparently it sets the file attribute at a sufficiently later point. Though, it's widely accepted practise to restrict usage of %attr to setting really special/unusual permissions (e.g. setuid, setgid, g-rx) and owner/group changes, so special attributes set with %attr really stick out (especially when using syntax highlighting). There's nothing in the packaging guidelines about it yet. Better not get used to using %attr for ordinary permissions that could be set in %install. In packages with many more files, if you needed to "fix" permissions, overusing %attr would reduce readability of the spec file a lot. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review