[Bug 979767] Review Request: kapow - A punch clock program

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=979767



--- Comment #8 from Christopher Meng <cickumqt@xxxxxxxxx> ---
No, you are doing something wrong:

%dir %{_datadir}/icons/hicolor/
%dir %{_datadir}/icons/hicolor/16x16/
%dir %{_datadir}/icons/hicolor/16x16/apps/
%dir %{_datadir}/icons/hicolor/22x22/
%dir %{_datadir}/icons/hicolor/22x22/apps/
%dir %{_datadir}/icons/hicolor/24x24/
%dir %{_datadir}/icons/hicolor/24x24/apps/
%dir %{_datadir}/icons/hicolor/32x32/
%dir %{_datadir}/icons/hicolor/32x32/apps/
%dir %{_datadir}/icons/hicolor/48x48/
%dir %{_datadir}/icons/hicolor/48x48/apps/
%dir %{_datadir}/icons/hicolor/64x64/
%dir %{_datadir}/icons/hicolor/64x64/apps/
%dir %{_datadir}/icons/hicolor/128x128/
%dir %{_datadir}/icons/hicolor/128x128/apps/
%dir %{_datadir}/icons/hicolor/256x256/
%dir %{_datadir}/icons/hicolor/256x256/apps/
%dir %{_datadir}/icons/hicolor/scalable/
%dir %{_datadir}/icons/hicolor/scalable/apps/

These dirs are used by other pkgs, too:

[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/icons/hicolor/256x256/apps(hicolor-icon-theme, fedora-logos),
     /usr/share/icons/hicolor/24x24(hicolor-icon-theme, fedora-logos),
     /usr/share/icons/hicolor/64x64/apps(hicolor-icon-theme),
     /usr/share/icons/hicolor/22x22(hicolor-icon-theme, fedora-logos),
     /usr/share/icons/hicolor/48x48/apps(hicolor-icon-theme, fedora-logos,
     metromap), /usr/share/icons/hicolor/22x22/apps(hicolor-icon-theme,
     fedora-logos), /usr/share/icons/hicolor/32x32/apps(hicolor-icon-theme,
     fedora-logos), /usr/share/icons/hicolor/48x48(hicolor-icon-theme, fedora-
     logos), /usr/share/icons/hicolor/24x24/apps(hicolor-icon-theme, fedora-
     logos), /usr/share/icons/hicolor/16x16/apps(hicolor-icon-theme, fedora-
     logos), /usr/share/icons/hicolor/scalable/apps(hicolor-icon-theme,
     fedora-logos), /usr/share/icons/hicolor/16x16(hicolor-icon-theme, fedora-
     logos), /usr/share/icons/hicolor/128x128/apps(hicolor-icon-theme),
     /usr/share/icons/hicolor/128x128(hicolor-icon-theme),
     /usr/share/icons/hicolor/64x64(hicolor-icon-theme), /usr/share/appdata
     (gnome-color-manager, ghex, baobab, gnome-contacts, gnome-calculator,
     gnome-documents, epiphany, gnome-system-monitor, simple-scan, gedit,
     filesystem, gnome-boxes), /usr/share/icons/hicolor/256x256(hicolor-icon-
     theme, fedora-logos), /usr/share/icons/hicolor(hicolor-icon-theme,
     fedora-logos), /usr/share/icons/hicolor/32x32(hicolor-icon-theme, fedora-
     logos), /usr/share/icons/hicolor/scalable(hicolor-icon-theme, fedora-
     logos)

My opinion is that you should keep original list but only add these two:

/usr/share/kapow, /usr/share/kapow/translations

to be owned.

Please fix issues above before import.

-----------

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review





[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]